search

lanl / NEONiso

R package for calibrating NEON atmospheric isotope data
https://lanl.github.io/NEONiso/
GNU General Public License v3.0
2 stars 2 forks source link

Updates for dev tidyselect #79

Closed hadley closed 2 years ago

hadley commented 2 years ago

Since .data is deprecated.

rfiorella commented 2 years ago

Thanks Hadley!

Is the .data deprecation documented anywhere? (checked the dplyr, tidyselect, rlang NEWS pages, but presumably this is a new change?) - I have a few other codes using .data that I'd like to make sure are updated consistent with this change.

I'm guessing it's related to this? https://github.com/r-lib/tidyselect/issues/169

codecov[bot] commented 2 years ago

Codecov Report

Merging #79 (6021841) into main (cc05ad2) will not change coverage. The diff coverage is 52.94%.

@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   46.05%   46.05%           
=======================================
  Files          19       19           
  Lines        1622     1622           
=======================================
  Hits          747      747           
  Misses        875      875
Impacted Files Coverage Δ
R/reference_data_selection.R 57.14% <50.00%> (ø)
R/restructure_data.R 65.70% <50.00%> (ø)
R/reference_data_extraction.R 56.09% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

hadley commented 2 years ago

It's in the news: https://github.com/r-lib/tidyselect/blob/main/NEWS.md. But I should make it more prominent...

rfiorella commented 2 years ago

Ah, thanks - got it! I had been looking at news at tidyselect.r-lib.org (dev updates not showing up there) and missed the version on GitHub. Thanks again!

hadley commented 2 years ago

Ooh hmmm, looks like the website isn't updating. Let me look into that.

hadley commented 2 years ago

Ooooh, no, we're just in a confusing state (which will be resolved on release) — you need to go to https://tidyselect.r-lib.org/dev/