search

lanl / PENNANT

Unstructured mesh hydrodynamics for advanced architectures
Other
20 stars 30 forks source link

Fix out-of-bounds errors in Mesh::initInvMap(). #9

Closed samuelkgutierrez closed 3 years ago

samuelkgutierrez commented 3 years ago

I've put together a small fix that appears to fix the out-of-bounds errors. I conducted some rudimentary testing on my end, and this update appears to also produce expected results.

jpietarilagraham commented 3 years ago

Thanks! master is Charles's code, but I'm going to merge this.

cferenba commented 3 years ago

Sam -

Thanks for finding this and fixing it! I’m amazed this has been in the code for so long without anyone noticing.

On Dec 14, 2020, at 3:05 PM, Samuel K. Gutiérrez notifications@github.com wrote:

I've put together a small fix that appears to fix the out-of-bounds errors. I conducted some rudimentary testing on my end, and this update appears to also produce expected results.

You can view, comment on, or merge this pull request online at:

https://github.com/lanl/PENNANT/pull/9

Commit Summary

• Fix out-of-bounds errors in Mesh::initInvMap(). File Changes

• M src/Mesh.cc (20) Patch Links:

• https://github.com/lanl/PENNANT/pull/9.patch • https://github.com/lanl/PENNANT/pull/9.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

======================================== Charles R. Ferenbaugh, Ph.D. CCS-7 - Applied Computer Science Los Alamos National Laboratory, MS D413 Los Alamos, NM 87545 505-665-7045 / cferenba@lanl.gov

samuelkgutierrez commented 3 years ago

Charles,

You are most welcome. This amazes me as well!