lanl / PyBNF

An application for parameterization of biological models available in SBML and BNGL formats. Features include parallelization, metaheuristic optimization algorithms, and an adaptive Markov chain Monte Carlo (MCMC) sampling algorithm.
Other
22 stars 18 forks source link

Bootstrap fix #203

Closed emitra17 closed 6 years ago

emitra17 commented 6 years ago

Fix error with bootstrapping with sum of squares objective. Closes #198

Need to confirm that this actually fixes things.

emitra17 commented 6 years ago

SumOfSquaresObjective was missing the multiplication by exp_data.weights[exp_row, exp_data.cols[col_name]]. I moved this factor to the superclass, so it affects all SummationObjectives.

ryants commented 6 years ago

Took me a bit to regain my bearings, but it looks good to me