search

lanl / RAM-SCB

RAM-SCB is a unique code that combines a kinetic model of ring current plasma with a three dimensional force-balanced model of the terrestrial magnetic field to simulate Earth's inner magnetosphere.
Other
13 stars 20 forks source link

Auto-detect NetCDF4 and GSL locations and flags #77

Closed drsteve closed 3 years ago

drsteve commented 3 years ago

The current Config.pl allows for specification of the locations of both NetCDF4 and GSL, but assumes a directory structure that isn't necessarily respected on system installs. It also requires the user to explicitly know where these libraries are located and appropriate flags are hard-coded.

This PR updates this by adding the option to use nf-config and gsl-config to look up the install locations and flags. The installation instructions in the README are also expanded.

Old behaviour is preserved. New behaviour is that supplying -ncdf and -gsl flags without a corresponding value will then attempt to use the config utilities to look up the location and flags for each dependent library.

(Edit to note that the force-push was after rebasing against master to ensure that the PR can be rebase-merged)

drsteve commented 3 years ago

Calling @Pheosics for review please!

Pheosics commented 3 years ago

@drsteve Looks good, this probably should have been included awhile ago

drsteve commented 3 years ago

Thanks @Pheosics - I'll go ahead and merge. I will note that we'll want to update the scheme options soon, as the settings are no longer good. We should also be able to use the auto settings for institutional users as long as all the selected modules are compatible (and built properly).