lanl / RAM-SCB

RAM-SCB is a unique code that combines a kinetic model of ring current plasma with a three dimensional force-balanced model of the terrestrial magnetic field to simulate Earth's inner magnetosphere.
Other
13 stars 20 forks source link

Update testing and Dockerfile to Ubuntu 20.04 #89

Closed drsteve closed 3 years ago

drsteve commented 3 years ago

Closes #88 and closes #81

All tests (test1, test2, test3, test4, testEMIC, testTravis, and testTravisLong) all pass on local.

drsteve commented 3 years ago

@Pheosics - When you get a minute can you take a quick look at this PR (and this one)

Pheosics commented 3 years ago

I did a quick glance today, it looks good. With moving to the GitHub CI do we want to expand the testing that gets done for the check? Currently only test 3 is run, it may be worthwhile also running test 2. Test 1 is almost guaranteed to pass if test 3 does, but test 2 exercises the restart so that could fail while test 3 passes.

drsteve commented 3 years ago

Yeah, I opened #90 with that question in mind...