search

lanl / SEPIA

Simulation-Enabled Prediction, Inference, and Analysis: physics-informed statistical learning.
Other
29 stars 6 forks source link

Need tests for sampling chains in parallel #35

Closed luiarthur closed 3 years ago

luiarthur commented 3 years ago

Currently, examples/Ball_Drop/ball_drop_1_parallel_chains contains tests that fail occasionally on MacOS and Windows.

I suspect the issues are related to parallel random seed generation or the use of multiprocessing.

Possible fixes are

  1. replacing multiprocessing with multiprocess.
  2. using rng = np.random.default_rng(seed) instead of setting a seed within a child process.
    • this might involve a huge refactoring and may not be needed if (1) works.
granthutchings commented 3 years ago

fixed using fix 1. above. Code change pushed to dev branch.