lanl / SEPIA

Simulation-Enabled Prediction, Inference, and Analysis: physics-informed statistical learning.
Other
33 stars 7 forks source link

create_D and create_K precursor checks #39

Open jgattiker opened 3 years ago

jgattiker commented 3 years ago

create_D and create_K basis methods should check that standardize_y and transform_xt have been completed. (otherwise it errors out in a puzzling way)

granthutchings commented 3 years ago
Screen Shot 2021-09-02 at 7 20 25 AM

Is this the error you are referring to?

granthutchings commented 3 years ago

Fixed here: a3a9c7f

Problem: In compute_sim_PCA_basis() we set y_std = sim_data.y_std, then do standardization if necessary. We continue referring to y_std but never reset y_std = sim_data.y_std so it remained NoneType even after calling standardize_y()