lanl / SEPIA

Simulation-Enabled Prediction, Inference, and Analysis: physics-informed statistical learning.
Other
33 stars 7 forks source link

setup_model not working with ragged #9

Closed granthutchings closed 4 years ago

granthutchings commented 4 years ago

checking that K_sim and K_obs have the same first dimension shape. Doesn't check if K_obs is a list first. ln 59.

natalieklein229 commented 4 years ago

just pushed a probable fix - can you check if it works now, and if not, paste the code you used to check it?

granthutchings commented 4 years ago

this is definately the right idea for fixing the problem but it doesn't quite work with np.all because the shapes are put into a list. in python np.all([2,2,2] == 2) is false but np.all(np.array([2,2,2]) == 2) is true so we just need the list shapes in an array not another list and it'll work!

natalieklein229 commented 4 years ago

try it now

granthutchings commented 4 years ago

Working. Thanks!