lanl / dfnWorks

dfnWorks is a parallelized computational suite to generate three-dimensional discrete fracture networks (DFN) and simulate flow and transport. If you download the software please fill out our interest form to stay up to date on releases https://goo.gl/forms/VE39oKsyp4LVC6Gj2 and join our google group https://groups.google.com/d/forum/dfnworks-users . Precompiled Docker Container https://hub.docker.com/r/ees16/dfnworks
https://dfnworks.lanl.gov/
Other
74 stars 42 forks source link

Curly brackets in comment #31

Closed nesetril closed 6 months ago

nesetril commented 2 years ago

If there is this comment:

regions:
{-5, 5, -10, 10, -20, 10} // {minX, maxX, minY, maxY, minZ, maxZ}

then {minX, maxX, minY, maxY, minZ, maxZ} shall be read instead of {-5, 5, -10, 10, -20, 10}

The error is: ValueError: could not convert string to float: 'minX'

hymanjd commented 2 years ago

Thank you for pointing this out. What file is the error in?

nesetril commented 2 years ago

/pydfnworks/dfnGen/generation/input_checking/parsing.py

line 318 float(value[0]),

hymanjd commented 2 years ago

Thank you. I mean the input file path.

nesetril commented 2 years ago

It is not in an example file available online. I made this in my dfnGen file.

hymanjd commented 2 years ago

okay. Thank you for letting me know.


Jeffrey Hyman Computational Earth Science (EES-16) Los Alamos National Laboratory 1 - (505) - 665 - 2074 @.***


From: KamCZa @.***> Sent: Saturday, June 18, 2022 9:40:59 AM To: lanl/dfnWorks Cc: Hyman, Jeffrey De'Haven; Comment Subject: [EXTERNAL] Re: [lanl/dfnWorks] Curly brackets in comment (Issue #31)

It is not in an example file available online. I made this in my dfnGen file.

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/lanl/dfnWorks/issues/31*issuecomment-1159485604__;Iw!!Bt8fGhp8LhKGRg!FzRLsAAYjTqu67Yb_7DBspSNBIFH0tbGrRBTB0vA5_0LbomNNbqNHZ6Xi_8cQyhwZEWHJ2-7N43SnqPiEZmPLtfS$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AEKOGDAKCYYYHO6B53ULIPLVPXUYXANCNFSM5Y2V5BPA__;!!Bt8fGhp8LhKGRg!FzRLsAAYjTqu67Yb_7DBspSNBIFH0tbGrRBTB0vA5_0LbomNNbqNHZ6Xi_8cQyhwZEWHJ2-7N43SnqPiEYgFgrOi$. You are receiving this because you commented.Message ID: @.***>

hymanjd commented 6 months ago

this was fixed by moving to v2.7