lanl / dfnWorks

dfnWorks is a parallelized computational suite to generate three-dimensional discrete fracture networks (DFN) and simulate flow and transport. If you download the software please fill out our interest form to stay up to date on releases https://goo.gl/forms/VE39oKsyp4LVC6Gj2 and join our google group https://groups.google.com/d/forum/dfnworks-users . Precompiled Docker Container https://hub.docker.com/r/ees16/dfnworks
https://dfnworks.lanl.gov/
Other
73 stars 42 forks source link

Some errors when running examples about version2.7 #51

Open Beniuy opened 1 year ago

Beniuy commented 1 year ago

Hello! Thank you very much for the software developed by your team, which has helped me a lot. I have the following problems during use. I run the example "user_polygon" in version 2.7 with native build, but it shows the error like this, image

Error 1 It runs successfully in version 2.6 with docker. I am sure that the parameter setting is the same. Error 2 I think the parameters have been defined in the file "driver.py",so there is no 'params.txt' might be true ? I can't understand the workflow in 'generator.py' as follows `if os.path.isfile("params.txt"):

    self.gather_dfn_gen_output()
    self.assign_hydraulic_properties()

    print('-' * 80)
    print("Generation Succeeded")
    print('-' * 80)
else:
    error = f"Error. Unable to find 'params.txt' in current directory {os.getcwd}.\n"
    sys.stderr.write(error)
    sys.exit(1)`

We look forward to your valuable comments! Yours sincerely

Beniuy commented 1 year ago

There are some other example errors when running V2.7 compared with V2.6 in docker. But the aforementioned problem is more confusing for me . Thanks !

hymanjd commented 1 year ago

Hi,

there was a key word missing in the driver.py file. It's been added to the master branch via commit

dd0dcb51cf4b315b257d11f493de78e91647dbd8

Let me know if that works for you.

J

Beniuy commented 1 year ago

Thanks! I have corrected the aforementioned error by adding the key word. However, there is a new error when calculating Richards Flow, it cannot converge. As a result ,I cannot get a water pressure result. image Tips: it runs correctly in version 2.5.

By the way, If I want to change to the old version, could I just unistall all the version 2.7 and reinstall pydfnworks 2.5 like the following? (I don't have to do anything about LagriT, PETSC, PFLOTRAN, Python, and FEHM paths, right?) 屏幕截图 2023-03-16 205642

Beniuy commented 1 year ago

It seems that I can not downgrade to version 2.6 or lower versions. Because it just provides this file ' dist/pydfnworks-2.7-py3-none-any.whl ' . 😄 I am looking forward to your help about the flow calculation error. Thank you very much !

hymanjd commented 1 year ago

yes, you'll need to roll back to a 2.6 commit.

Beniuy commented 1 year ago

In the old version, the aperture.dat shows all the fractures keep the same aperture 1e-5 image However, in the latest version, the aperture.dat shows only the first one has the expected aperture 1e-5, while the others remain zero. I think this might be the error. image image The latest version define the aperture in the driver.py with the function 'add_user_fract_from_file', I think it doesn't define all the apertures for every fracture.

hymanjd commented 1 year ago

@aidanstansberry what do you think is going on?

aidanstansberry commented 1 year ago

It appears that when assigning the hydraulic properties we incorrectly assume that there is only one fracture defined in the file. This will only be a problem when using add_user_fract_from_file(). I am working on a fix right now.