search

lanl / palm_lanl

LANL Contributions to PArallelized Large-eddy simulation Model (PALM)
2 stars 5 forks source link

Bugfix for reference density used in buoyancy term #58

Closed cbegeman closed 4 years ago

cbegeman commented 4 years ago

Indices were interchanged in the assignment of reference density used in the numerator of the buoyancy term of the momentum equation. This is now fixed.

Also included in this PR is an unrelated update to the default namelist file. The default mode for ocean runs is to use a single reference density value (as opposed to a spatially varying value) in the momentum equation. The constant flux layer is also off by default, which the default namelist now reflects.

cbegeman commented 4 years ago

@katsmith133 This was the source of the difficulty running the free convection test case. Once this is merged you should be good to go!

cbegeman commented 4 years ago

@xylar Do you mind if I go ahead and merge? It's a straightforward bugfix.

xylar commented 4 years ago

Go for it!