I noticed that when running outside of scale_free mode with radiation, the mean opacities are incorrect. This is because the mean opacity constructors expect an opacity without a unit conversion, e.g. Gray, whereas in phoebus outside of scale_free mode we pass in e.g. NonCGSUnits<Gray>.
My solution, to store both CGS and non-CGS host opacities, is a bit yucky. I wonder if this further motivates a singularity-opac refactor to deal also with the issue of too many variants brought up by @Yurlungur previously.
PR Summary
PR Checklist
[ ] Adds a test for any bugs fixed. Adds tests for new features.
[x] Format your changes by calling scripts/bash/format.sh.
I noticed that when running outside of
scale_freemode with radiation, the mean opacities are incorrect. This is because the mean opacity constructors expect an opacity without a unit conversion, e.g.Gray, whereas in phoebus outside ofscale_freemode we pass in e.g.NonCGSUnits<Gray>.My solution, to store both CGS and non-CGS host opacities, is a bit yucky. I wonder if this further motivates a
singularity-opacrefactor to deal also with the issue of too many variants brought up by @Yurlungur previously.PR Summary
PR Checklist
scripts/bash/format.sh.