search

lanl / phoebus

Phifty One Ergs Blows Up A Star
BSD 3-Clause "New" or "Revised" License
32 stars 0 forks source link

Jmm/update for chicoma #177

Closed Yurlungur closed 1 year ago

Yurlungur commented 1 year ago

PR Summary

Chicoma requires new and exciting changes to run. This PR incorporates those changes. These changes are:

  1. Update to parthenon develop, due to the requirement of Kokkos 4. This necessitated some changes in the driver and boundary conditions to conform to Parthenon's current API. It also enabled me to thread through restart-able params. @mari2895 and @curiousmiah : this means that restarts should now work for self-gravity. @AstroBarker : I didn't thread the restart changes through the monte carlo control variables, but you can see from this diff how it's done.
  2. I added nvcc_wrapper to scripts/bash. This is a modified version of the wrapper provided by Kokkos but specifically set up to pass appropriate flags when building with the nvhpc environment. You can build as normally most places, but when building with nvhpc you should set -DCMAKE_CXX_COMPILER=path/to/phoebus/scripts/bash/nvcc_wrapper. Note you need the full path.

PR Checklist

Yurlungur commented 1 year ago

@brryan did you get to check this yet?

@mari2895 @AstroBarker please try it again should work now.

AstroBarker commented 1 year ago

Built and running on Chicoma with the latest changes