lanl / phoebus

Phifty One Ergs Blows Up A Star
BSD 3-Clause "New" or "Revised" License
46 stars 2 forks source link

Inconsistent behavior between CPU and GPU for liebendorf deleptonization and cooling #184

Closed carlnotsagan closed 10 months ago

carlnotsagan commented 1 year ago

Issue:

when using cooling_function with SASW/homologous problem. returns error:

:0: : block: [3,0,0], thread: [0,0,0] AssertionView bounds error of view p.densityfailed.

after first step

this backtraces to:

the cooling function

Host function was being called from device function leading to issues on GPU.


Steps Taken:

Yurlungur commented 1 year ago

@carlnotsagan do you encounter the same issue when running lightbulb with @mari2895 's CCSN problem initialization? If not maybe it has to do with changes in the SASW branch? Can you share the code for SASW in a PR?

carlnotsagan commented 11 months ago

thanks for merging main, should be all good now

Yurlungur commented 11 months ago

Looks like tests are still failing?

carlnotsagan commented 11 months ago

looking into the fails. something to do with a reference to pmb