search

lanl / phoebus

Phifty One Ergs Blows Up A Star
BSD 3-Clause "New" or "Revised" License
32 stars 0 forks source link

entropy added in outputs #201

Closed mari2895 closed 6 months ago

mari2895 commented 6 months ago

PR Summary

entropy added in outputs

PR Checklist

AstroBarker commented 6 months ago

Not sure why the bondi test is crashing, but it's happening locally, too. Looking into it..

jonahm-LANL commented 6 months ago

Sparse packs require you always pass in a block index. For meshblockdata, just pass in 0 like you suggest

Get Outlook for iOShttps://aka.ms/o0ukef

From: Brandon Barker @.> Sent: Monday, March 4, 2024 5:42:16 PM To: lanl/phoebus @.> Cc: Miller, Jonah Maxwell @.>; Review requested @.> Subject: [EXTERNAL] Re: [lanl/phoebus] entropy added in outputs (PR #201)

@AstroBarker commented on this pull request.

In src/phoebus_driver.cpphttps://urldefense.com/v3/__https://github.com/lanl/phoebus/pull/201*discussion_r1511982543__;Iw!!Bt8fGhp8LhKGRg!Aph7d-ailVON-bABJXZcG2_3mipzsDM_0x_49l1zPQMPH1-3sQUvZQBLgfdEqa_V1ge7kEPr1TXriei1Z5PuGSy1$:

*/ void UserWorkBeforeOutput(MeshBlock pmb, ParameterInput *pin) { auto tracer_pkg = pmb->packages.Get("tracers"); bool do_tracers = tracer_pkg->Param("active"); +

  • namespace p = fluid_prim;
  • auto rc = pmb->meshblock_data.Get().get();
  • PackIndexMap imap;
  • auto v = rc->PackVariables(

Looks like the reason for the crash was not having a block index as the first arg to the pack? e.g., doing v(0, p::density, k, j, i) gets rid of the crash. Do the sparse packs not support not passing that arg? Or is it set up wrong here? (I hid your comment @mari2895https://urldefense.com/v3/__https://github.com/mari2895__;!!Bt8fGhp8LhKGRg!Aph7d-ailVON-bABJXZcG2_3mipzsDM_0x_49l1zPQMPH1-3sQUvZQBLgfdEqa_V1ge7kEPr1TXriei1ZyxF0IS0$ because it was really long, sorry)

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/lanl/phoebus/pull/201*discussion_r1511982543__;Iw!!Bt8fGhp8LhKGRg!Aph7d-ailVON-bABJXZcG2_3mipzsDM_0x_49l1zPQMPH1-3sQUvZQBLgfdEqa_V1ge7kEPr1TXriei1Z5PuGSy1$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AOO5OJ2CAGBQMSE4GBCU7XDYWUIGRAVCNFSM6AAAAABEFXYJPCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMJVGYZTEMBYGU__;!!Bt8fGhp8LhKGRg!Aph7d-ailVON-bABJXZcG2_3mipzsDM_0x_49l1zPQMPH1-3sQUvZQBLgfdEqa_V1ge7kEPr1TXriei1Z2K6HHxm$. You are receiving this because your review was requested.Message ID: @.***>