lanl / phoebus

Phifty One Ergs Blows Up A Star
BSD 3-Clause "New" or "Revised" License
32 stars 0 forks source link

ReduceMassAccretionRate cannot use `MeshData` pointer on device #208

Closed Yurlungur closed 6 months ago

Yurlungur commented 6 months ago

@mari2895 and I discovered a bug in the mass accretionr ate code. It looks like the MeshData<Real> pointer md. We can't do this as the MeshData pointer is a host memory object and the loop is in device memory space. This will crash or cause other issues.

AstroBarker commented 6 months ago

Thanks for catching this. Working on it in #209. If I misunderstood the issue let me know

Yurlungur commented 6 months ago

Caused by confusion between branches.