lanl / phoebus

Phifty One Ergs Blows Up A Star
BSD 3-Clause "New" or "Revised" License
32 stars 0 forks source link

Add eos information to floors, misc UserWorkBeforeOutput fix #210

Closed AstroBarker closed 5 months ago

AstroBarker commented 6 months ago

This PR adds knowledge of eos bounds to the floors. Specifically, for tabulated EOS, demand that the floors do not extrapolate off of the table. This required making the bounds param mutable.

Currently, for ideal gas, the option to enforce user set bounds is supported by supplying, e.g., <eos>/rho_min in the input deck. If unspecified, reasonable defaults are set.

Also fixed a misc bug in the UserWorkBeforeOutput code where a package and param were pulled out inside a device kernel that caused a crash on device.

Yurlungur commented 5 months ago

Ready for re-review, @AstroBarker ?

AstroBarker commented 5 months ago

Ready for re-review, @AstroBarker ?

Good to go