search

lanl / phoebus

Phifty One Ergs Blows Up A Star
BSD 3-Clause "New" or "Revised" License
46 stars 2 forks source link

Check for spacetime/problem consistency #22

Closed brryan closed 3 years ago

brryan commented 3 years ago

Currently the spacetime/coordinates are set at compile time but the problem is chosen at runtime. Problems should check that the code is compiled with the correct spacetime for them.

brryan commented 3 years ago

Is there a way to force all problem statements to check the spacetime? Some internal variable that problem statements have to set that is then checked internally?

Yurlungur commented 3 years ago

In the pgen, you can check the type of the geometry. Do we need more than that? Like some formal machinery? Some problem generators work for multiple geometries... Shock tube and linear modes, for example, work for multiple "coordinate systems" of Minkowski.

brryan commented 3 years ago

This has been resolved, although on a per-problem file basis.