This PR switches primitive velocity variables from v^i = u^i/Gamma + beta^i/alpha to vp^i = u^i + Gamma beta^i / alpha. This latter definition, commonly used in GRMHD codes, has the advantage that it is valid in the range (-infinity, infinity), rather than ~(-1, 1).
I also add a compile-time option, PHOEBUS_VALENCIA=ON/OFF, to switch from the Valencia non-conservative energy equation to the covariant conservative energy equation, in the hope that the hydrostatic torus will behave better.
[x] Update remaining problem files to use new primitive velocity
[x] Fix weird issue at outer edge of disk with conservative energy eqn
This PR switches primitive velocity variables from
v^i = u^i/Gamma + beta^i/alpha
tovp^i = u^i + Gamma beta^i / alpha
. This latter definition, commonly used in GRMHD codes, has the advantage that it is valid in the range (-infinity, infinity), rather than ~(-1, 1).I also add a compile-time option,
PHOEBUS_VALENCIA=ON/OFF
, to switch from the Valencia non-conservative energy equation to the covariant conservative energy equation, in the hope that the hydrostatic torus will behave better.printf
s