search

lanl / phoebus

Phifty One Ergs Blows Up A Star
BSD 3-Clause "New" or "Revised" License
32 stars 0 forks source link

Specify "hydro" unit set #65

Open Yurlungur opened 2 years ago

Yurlungur commented 2 years ago

Something like density, sie, and temperature units might be convenient as a setable option.

Yurlungur commented 2 years ago

Also being able to set non-trivial temperature units might be nice.

brryan commented 2 years ago

Yeah this is probably a good idea, probably the best way to do it would be to label a set of possible ways to set the units with a string, something like

<units>
conversion = none # none, blackhole, flatspace, hydro

and the unit conversion system then pulls the appropriate conversions out of the parameter file. Right now we just require a mass or length if setting a unit conversion.