search

lanl / phoebus

Phifty One Ergs Blows Up A Star
BSD 3-Clause "New" or "Revised" License
46 stars 2 forks source link

ratios and bounds #67

Closed Yurlungur closed 2 years ago

Yurlungur commented 2 years ago

In this PR I do some cleanup suggested by @brryan in MR #63 . Note this is based off of that branch, so we need to merge that one first.

In particular I move Geometry::Utils::ratio into robust.hpp. I also combine it with the ratio function in closure.hpp. I believe my combination should work, but @lroberts36 should double check me.

Finally I fix the weird difference between Phoebus boundary condition naming and Parthenon boundary condition naming, so the phoebus names are consistent with the parthenon ones.

WIP because I haven't had time to do any testing.

Yurlungur commented 2 years ago

Now have tested it and it seems to behave. At least for unit tests. I had to make SMALL a function or cuda yelled at me.

Yurlungur commented 2 years ago

@lroberts36 @brryan @jdolence with the parent branch now merged, this is ready for review.

Yurlungur commented 2 years ago

I just merged in main. Hopefully that fixes the weirdness with #63?

Yurlungur commented 2 years ago

Okay @lroberts36 I also renamed SMALL to EPS and added a new SMALL corresponding to std::numeric_limits<T>::min. I also pulled a few direct access to these constexprs out and replaced them with the appropriate robustify functions.

Yurlungur commented 2 years ago

Thanks for the review! Merging.