Closed Yurlungur closed 2 years ago
Now tested and seems to behave itself.
If no one reviews this by the end of day today, I will merge it by fiat.
Thanks, @lroberts36 ! I addressed all your comments and will go ahead and merge now.
or as soon as tests pass
PR Summary
As we discussed, we currently use lagged variables (i.e., from one subcycle behind) to source the monopole solver. We decided that a totally un-lagged procedure is, at the moment, not desirable. These changes are intended to lend a bit more confidence to our current approach.
I add two features that should add confidence:
dtfac * alpha/(dalpha/dt)
, which provides an approximate characteristic time scale for metric evolution. There's no stability criterion here... But presumably if we are taking time steps larger than the metric evolution time scale, then lagging our variables is certainly wrong.Interested to hear what people think.
PR Checklist
scripts/bash/format.sh
.