Change behavior of `require` to match documentation

lanl / ports-of-call

Performance Portability Utilities

https://lanl.github.io/ports-of-call/

BSD 3-Clause "New" or "Revised" License

2 stars 1 forks source link

Change behavior of `require` to match documentation #30

Closed jhp-lanl closed 1 year ago

jhp-lanl commented 1 year ago

PR Summary

If we 'require' something, then the failed condition should trigger the error message, not the success. This small change brings the code in line with the documentation and my understanding of the intent of the REQUIRE macros.

PR Checklist

[x] Any changes to code are appropriately documented.
[x] Code is formatted.
[x] Install test passes.
[x] Docs build.
N/A If preparing for a new release, update the version in cmake.

jhp-lanl commented 1 year ago

@Yurlungur let me know if I'm missing something, but it looks like require() should only have an error when the condition is false rather than true.