First cut at adding printf, help builds.

lanl / ports-of-call

Performance Portability Utilities

https://lanl.github.io/ports-of-call/

BSD 3-Clause "New" or "Revised" License

2 stars 1 forks source link

First cut at adding printf, help builds. #40

Closed dholladay00 closed 7 months ago

dholladay00 commented 7 months ago

PR Summary

This adds an internal print function used by portable errors machinery that stubs out printf on hip where printf doesn't exist.

[ ] Should we make this more public for use by downstream codes (probably).
[ ] Should we figure out a way to call out to kokkos printf if its available (only available on very new versions of kokkos).

@Yurlungur @mauneyc-LANL @rbberger @chadmeyer

PR Checklist

[ ] Any changes to code are appropriately documented.
[ ] Code is formatted.
[ ] Install test passes.
[ ] Docs build.
[ ] If preparing for a new release, update the version in cmake.

dholladay00 commented 7 months ago

This works sufficiently for our purposes as this change-set gets help to build on rzvernal @Yurlungur, the question is do we want to do a bunch of complicated stuff to add the kokkos version for sufficiently new versions of kokkos? If not (I am leaning in this direction) we can remove some comments.

The other question @Yurlungur is should be remove this from impl namespace and put it in a public facing namespace? I think yes as downstream codes will likely want this thing if they want to build with hip.

Yurlungur commented 7 months ago

Broadly, I concur:

This works sufficiently for our purposes as this change-set gets help to build on rzvernal @Yurlungur, the question is do we want to do a bunch of complicated stuff to add the kokkos version for sufficiently new versions of kokkos? If not (I am leaning in this direction) we can remove some comments.

No---let's wait until that's just the version we depend on. We can do what you did here until then,

The other question @Yurlungur is should be remove this from impl namespace and put it in a public facing namespace? I think yes as downstream codes will likely want this thing if they want to build with hip.

Yes, let's put it in the public namespace.

Yurlungur commented 7 months ago

@dholladay00 let me know when this is ready for review/merge

dholladay00 commented 7 months ago

@Yurlungur are there additional tests on Darwin that I can run or is this sufficient? This is ready to go pending necessary testing if not already accomplished.