search

lanl / scico

Scientific Computational Imaging COde
BSD 3-Clause "New" or "Revised" License
101 stars 17 forks source link

`ADMM` initializer supports setting `f=None` #376

Open bwohlberg opened 1 year ago

bwohlberg commented 1 year ago

While not documented, the ADMM class __init__ supports setting f=None. This capability is used in several example scripts, e.g.

https://github.com/lanl/scico/blob/029a595e562420cb4e4559995d0b7808448d1c0d/examples/scripts/denoise_l1tv_admm.py#L62-L64

This support should either be documented or removed. The latter is perhaps cleaner since the same effect can be achieved by setting f to a ZeroFunctional object.

bwohlberg commented 1 year ago

Agreement reached to remove support for f = None.