lanl / scico

Scientific Computational Imaging COde
BSD 3-Clause "New" or "Revised" License
90 stars 17 forks source link

ADMM's CircularConvolveSolver not using all the parameters specified #528

Closed crstngc closed 3 weeks ago

crstngc commented 4 weeks ago

The internal initialization of CircularConvolveSolver usesCircularConvolve.from_operator:

https://github.com/lanl/scico/blob/07a41c6652b94a3324b51e146ece22cc0f655649/scico/optimize/_admmaux.py#L414C19-L414C60

ignoring associated parameters (e.g. ndims, center) that may have been included in the configuration of the ADMM solver. This leads to convolutions being applied by default over all the axes even when only a subset of them is intended.