Add lambda thermalq - Githubissues

lanl / singularity-eos

Performance portable equations of state and mixed cell closures

https://lanl.github.io/singularity-eos/

BSD 3-Clause "New" or "Revised" License

27 stars 8 forks source link

Add lambda thermalq #362

Closed Yurlungur closed 6 months ago

Yurlungur commented 6 months ago

PR Summary

As discussed with @dholladay00 and @gopsub , this adds lambda to the thermalqs list, allowing, on a per-EOS basis, users to request FillEos to do something with input lambdas.

PR Checklist

[x] Adds a test for any bugs fixed. Adds tests for new features.
[x] Format your changes by using the make format command after configuring with cmake.
[x] Document any new features, update documentation for changes made.
[x] Make sure the copyright notice on any files you modified is up to date.
[x] After creating a pull request, note it in the CHANGELOG.md file.
[x] LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

[ ] Update the version in cmake.
[ ] Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.

jhp-lanl commented 6 months ago

Looks like this breaks the python bindings somehow. I don't think it should be too hard to fix.

 45/46 Test #45: PythonBindings .....................................................................***Failed    0.31 sec
      Start 46: test_fortran_interface

Can you run on gitlab as well just to make sure it doesn't break anything else?

dholladay00 commented 6 months ago

[x] you'll need to add this to the docs list. using-eos.rst roughly round line 490
[x] python/module.cpp needs lambda attribute added
[x] test/python_bindings needs a correction to a test calculation by adding an addition | lambda to the test value

Yurlungur commented 6 months ago

Thanks @jhp-lanl @dholladay00 should be fixed now. Tests running on re-git.

Yurlungur commented 6 months ago

OK not sure why the python bindings are still failing... @rbberger any insight?

rbberger commented 6 months ago

OK not sure why the python bindings are still failing... @rbberger any insight?

Maybe because lambda is a reserved keyword in Python?

Yurlungur commented 6 months ago

OK not sure why the python bindings are still failing... @rbberger any insight?

Maybe because lambda is a reserved keyword in Python?

Hmm... possible. I'll try do_lambda

Yurlungur commented 6 months ago

That worked! Thanks @rbberger !

Ok tests now all apss here. Checking on re-git as well. Ready for re-review, @dholladay00 @gopsub @jhp-lanl @rbberger

Yurlungur commented 6 months ago

Looks like tests are still failing on Roci due to a failed git clone. (@rbberger is this expected? Maybe related to the issues @dholladay00 reported on the mattermost?) However, everything else is passing. I think it's safe to review this and merge it now.