Closed jhp-lanl closed 5 months ago
@chadmeyer please review these changes and see if you agree with my approach
@chadmeyer I think I addressed all your comments. I'll give things another scan and make sure I didn't miss anything else silly, but I think this is good now.
FYI - I added a few more robustness additions. Mainly I added an error to the DensityEnergyFromPressureTemperature()
functions if the resultant density is negative (adding a max here probably will just cause the function to not converge and produce a less informative error).
I also added a robust::ratio
to where we divide by Ts
. It is possible for this to underflow which might be zero.
PR Summary
Three primary additions to the Davis Reactants and Products EOS to make them more robust:
robust::ratio
function when dividing by densityPR Checklist
make format
command after configuring withcmake
.If preparing for a new release, in addition please check the following: