lanl / spiner

Performance portable routines for generic, tabulated, multi-dimensional data
https://lanl.github.io/spiner
BSD 3-Clause "New" or "Revised" License
7 stars 3 forks source link

[JOSS REVIEW] Fix plotting convergence #39

Closed lgarrison closed 2 years ago

lgarrison commented 2 years ago

Small CMake fix needed to get make convergence to run. I think the numpy/matplotlib check was actually failing before due to a misnamed variable, but it looked like it was passing because the MATPLOTLIB_FOUND check was accepting a return code of 1 as a "pass".

The original error was: /bin/sh: plot_convergence.py: command not found.

lgarrison commented 2 years ago

x-ref: https://github.com/openjournals/joss-reviews/issues/4367