lanl / spiner

Performance portable routines for generic, tabulated, multi-dimensional data
https://lanl.github.io/spiner
BSD 3-Clause "New" or "Revised" License
7 stars 3 forks source link

kokkos test support older kokkos #47

Closed Yurlungur closed 2 years ago

Yurlungur commented 2 years ago

PR Summary

@ktsai7 pointed out a test was failing on Power9s. @rbberger found that the reason was that we are using an older Kokkos on that system, and it doesn't support cuda-relaxed-constexpr. The test relied on this to move a std::array to device via lambda capture.

This change removes the need for that, by instead using a Kokkos::View. I also got annoyed waiting for 1e9 points to be evaluated, so I reduce to 1e6 points.

PR Checklist

Yurlungur commented 2 years ago

I also clean up formatting a bit.