lanl / spiner

Performance portable routines for generic, tabulated, multi-dimensional data
https://lanl.github.io/spiner
BSD 3-Clause "New" or "Revised" License
7 stars 3 forks source link

Spack/CI updates #53

Closed rbberger closed 1 year ago

rbberger commented 1 year ago

PR Summary

PR Checklist

rbberger commented 1 year ago

@Yurlungur Unlike ports-of-call, this repo has a GitLab pipeline that pulls in its doc dependencies via Spack. But I might still remove the +doc variant in the public facing Spack package in upstream.

Yurlungur commented 1 year ago

Assume this is for the header-only version of ports-of-call with portability strategy removed?

@Yurlungur Unlike ports-of-call, this repo has a GitLab pipeline that pulls in its doc dependencies via Spack. But I might still remove the +doc variant in the public facing Spack package in upstream.

I'm in favor of this. Let's just remove the doc build from the gitlab workflow, since github is building for us

rbberger commented 1 year ago

@Yurlungur Yes, please see my comment in the re-git instance. It does come with a cost, not sure how important that other pages instance is.

rbberger commented 1 year ago

@Yurlungur the GitHub action failure seems to be caused by a newer ubuntu image that now uses GCC 11.3 instead of 9.4.0

rbberger commented 1 year ago

@Yurlungur Updating the Catch2 dependency fixed the issue. Also cleaned up the broken submodule state (.gitmodules entry was ignored, since the folder wasn't commited anymore)