lanl / spiner

Performance portable routines for generic, tabulated, multi-dimensional data
https://lanl.github.io/spiner
BSD 3-Clause "New" or "Revised" License
7 stars 3 forks source link

CMake macros to functions #58

Closed mauneyc-LANL closed 1 year ago

mauneyc-LANL commented 1 year ago

PR Summary

The content CMake code was written as a macro. This changes them to function. The significance here is scoping: macro works like C-preprocessor macros, and just blots the code block into the call site. function creates a new, isolated scope.

The benefit here is to keep variables created in a function "inside" the function scope, so they don't pollute the calling namespace. This was causing name-collision issues with updates to singularity-eos downstream (https://github.com/lanl/singularity-eos/pull/221)

2023-02-14

Some sundry updates that are tagging along (mostly from co-developing updates in singularity-eos):

PR Checklist

Yurlungur commented 1 year ago

@mauneyc-LANL what's the status of this PR? Should we close it for now? Or do you plan to return to it?

mauneyc-LANL commented 1 year ago

Not required anymore