lanl / spiner

Performance portable routines for generic, tabulated, multi-dimensional data
https://lanl.github.io/spiner
BSD 3-Clause "New" or "Revised" License
7 stars 3 forks source link

Initial commit to remove kokkos specific code for copying views, base… #64

Closed dholladay00 closed 1 year ago

dholladay00 commented 1 year ago

…d on new ports-of-call capabilities.

This PR removes kokkos specific code from spiner for the getondevice function. Addresses #54

@mauneyc-LANL @Yurlungur please take a look. I think poc needs more functionality to expose information about memory/execution spaces so that I don't need the hacky preprocessor stuff.

I should also note that this won't work until the latest changes from ports-of-call are pulled in.

PR Summary

PR Checklist

Yurlungur commented 1 year ago

Thanks @dholladay00 overall this looks great. We should incorporate @mauneyc-LANL 's changes in ports of call before merge.

dholladay00 commented 1 year ago

@Yurlungur this is now passing gitlab CI and GitHub tests, I think it's ready.