fix getondevice

[Yurlungur]

PR Summary

Even with only host context, it turns out Kokkos::Malloc and Kokkos::Free are not just the standard malloc and free. What this means is that if you build Spiner with Kokkos backend but no device, it's still dangerous to mix PORTABLE_MALLOC with free. This was causing a segfault in this particular edge case. Now fixed.

In the long term, to catch such things, we should probably add a Kokkos serial build to the Spiner CI. I didn't bother for now though.

PR Checklist

• [x] Code is formatted. (You can use the format_spiner make target.)
• [ ] Adds a test for any bugs fixed. Adds tests for new features.
• [ ] If preparing for a new release, update the version in cmake.

[dholladay00]

The kokkos malloc behavior will be both platform and compiler dependent as well.

[dholladay00]

If we match each portable malloc with a portable free wouldn't that be the best way to resolve?

[Yurlungur]

If we match each portable malloc with a portable free wouldn't that be the best way to resolve?

That is what this fix does. The error was that by setting AllocationStatus to allocated host, it was matching a portable malloc with a free, where it should have been a portable free.

[Yurlungur]

Tests pass on re-git. Pulling the trigger.