lanl / vpic

Vector Particle-In-Cell (VPIC) Project
Other
152 stars 76 forks source link

add user defined buffers #109

Closed petschge closed 4 years ago

petschge commented 4 years ago

as described in issue #98.

codecov[bot] commented 4 years ago

Codecov Report

Merging #109 into global_particle_id will decrease coverage by 2.23%. The diff coverage is 64.80%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           global_particle_id     #109      +/-   ##
======================================================
- Coverage               82.83%   80.60%   -2.24%     
======================================================
  Files                     120      123       +3     
  Lines                    7452     8548    +1096     
  Branches                 1159     1436     +277     
======================================================
+ Hits                     6173     6890     +717     
- Misses                    781     1026     +245     
- Partials                  498      632     +134     
Impacted Files Coverage Δ
src/species_advance/standard/sort_p.cc 50.00% <ø> (ø)
src/util/checkpt/checkpt.cc 64.50% <ø> (+0.15%) :arrow_up:
src/vpic/misc.cc 45.07% <0.00%> (-3.42%) :arrow_down:
src/vpic/vpic.h 85.00% <ø> (+0.78%) :arrow_up:
test/integrated/particle_IDs/particle_IDs.deck 59.17% <ø> (ø)
src/species_advance/species_advance_aos.h 37.50% <37.50%> (ø)
src/vpic/advance.cc 72.61% <50.00%> (-0.36%) :arrow_down:
src/vpic/dump.cc 58.23% <51.31%> (-11.31%) :arrow_down:
...ecies_advance/standard/pipeline/sort_p_pipeline.cc 77.89% <60.34%> (-17.23%) :arrow_down:
...rated/particle_annotation/particle_annotation.deck 72.35% <72.35%> (ø)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2d77a10...e2b2fc6. Read the comment docs.

rfbird commented 4 years ago
CMakeFiles/vpic.dir/src/grid/grid_comm.cc.o -c /home/travis/build/lanl/vpic/src/grid/grid_comm.cc
/home/travis/build/lanl/vpic/src/vpic/dump.cc: In member function ‘void vpic_simulation::init_buffered_particle_dump(const char*, int, double)’:
/home/travis/build/lanl/vpic/src/vpic/dump.cc:904:10: error: ‘class species_t’ has no member named ‘output_buffer_id’
   if(sp->output_buffer_id) { FREE_ALIGNED(sp->output_buffer_id); sp->output_buffer_id = nullptr; }

It also looks like travis found some guard missmatches

petschge commented 4 years ago

It also looks like travis found some guard missmatches

Yes. That's what I get for not running my compile checks locally. Will get fixed in the next commit.