lanl / vpic

Vector Particle-In-Cell (VPIC) Project
Other
151 stars 76 forks source link

Support for in situ time average of fields, take 2 #110

Closed dnystrom1 closed 4 years ago

dnystrom1 commented 4 years ago

Added changes to src/vpic/dump.cc and src/vpic/vpic.h originally implemented by Brian Albright to allow passing of the field to be dumped via an optional argument to relevant functions. The use case for this is to allow creation of a separate field to hold a time average of a given field which can then be time averaged in situ instead of dumping the field at a higher frequency and then performing the time average as a post-processing step. This greatly reduces the amount of IO which needs to be performed and the number of file system inodes that need to be used for large scale runs performed by some users. Use of an optional argument to the function allows for backward compatibility of existing input decks.

If at first you do not succeed, try, try again.

codecov[bot] commented 4 years ago

Codecov Report

Merging #110 into devel will decrease coverage by 0.02%. The diff coverage is 55.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #110      +/-   ##
==========================================
- Coverage   83.17%   83.15%   -0.03%     
==========================================
  Files         118      118              
  Lines        7280     7289       +9     
  Branches     1120     1124       +4     
==========================================
+ Hits         6055     6061       +6     
  Misses        752      752              
- Partials      473      476       +3     
Impacted Files Coverage Δ
src/vpic/dump.cc 68.73% <55.00%> (-0.81%) :arrow_down:
src/vpic/vpic.h 84.74% <100.00%> (ø)
src/util/pipelines/pipelines_thread.cc 64.48% <0.00%> (+2.80%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6a1e891...aff15a9. Read the comment docs.