search

lanl / vpic

Vector Particle-In-Cell (VPIC) Project
Other
151 stars 76 forks source link

Reduce Print Output #116

Closed rfbird closed 4 years ago

rfbird commented 4 years ago

Remove warnings about changing the size of the particle array when dynamic resizing is on

codecov[bot] commented 4 years ago

Codecov Report

Merging #116 into devel will increase coverage by 0.02%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #116      +/-   ##
==========================================
+ Coverage   83.13%   83.15%   +0.02%     
==========================================
  Files         118      118              
  Lines        7289     7286       -3     
  Branches     1124     1124              
==========================================
- Hits         6060     6059       -1     
+ Misses        753      751       -2     
  Partials      476      476
Impacted Files Coverage Δ
src/boundary/boundary_p.cc 86.01% <ø> (+0.29%) :arrow_up:
src/util/pipelines/pipelines_thread.cc 64.48% <0.00%> (+0.93%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3c1eec2...b326560. Read the comment docs.

SVLuedtke-LANL commented 4 years ago

I also got rid of the warning when resizing the mover arrays. This is a lot less scary than when I first wrote it because I have since written a test that hits that part of the code and also seen it in the wild, and it seemed to work just fine. If my comments look okay, I support this for merge to devel.

rfbird commented 4 years ago

OK, sounds good. I had left that in because it's easier for the user to control, and not something we shrink for them. I'm happy either way so will merge