search

lanl / vpic

Vector Particle-In-Cell (VPIC) Project
Other
151 stars 76 forks source link

Replaced ints with unsigned versions in dumpmacros.h #127

Closed agseaton closed 3 years ago

agseaton commented 3 years ago

This commit resolves #126

In addition to the tests described on the issue tracker, I've run the harris deck and diffed the field dumps produced by this commit and the devel branch. This indicated there was no change.

codecov[bot] commented 3 years ago

Codecov Report

Merging #127 into devel will increase coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #127      +/-   ##
==========================================
+ Coverage   83.12%   83.14%   +0.01%     
==========================================
  Files         118      118              
  Lines        7267     7267              
  Branches     1120     1120              
==========================================
+ Hits         6041     6042       +1     
  Misses        753      753              
+ Partials      473      472       -1
Impacted Files Coverage Δ
src/util/pipelines/pipelines_thread.cc 63.55% <0.00%> (+0.93%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e472b0d...edde10e. Read the comment docs.

agseaton commented 3 years ago

Yep that sounds sensible - I'm 99.9% sure this is fine but doesn't hurt to be extra careful!