brtnfld commented 3 years ago

This is Bin's update_strategy work which is in sync with devel. This is proposed to replace the current dump_strategy branch.

A couple of issues:

(1) the perform_restore test was disabled (like in the current dump strategy branch); we might want to enable that again. (1a) buffered_particle test was disabled because buffered_particle_dump_restart fails, need to fix.

(3) UNVOXEL is not in devel.

ctest passes (minus tests noted)

codecov[bot] commented 3 years ago

Codecov Report

Merging #144 (417f23a) into devel (6e98503) will decrease coverage by 4.33%. The diff coverage is 34.32%.

:exclamation: Current head 417f23a differs from pull request most recent head 9982d79. Consider uploading reports for the commit 9982d79 to get more accurate results

@@            Coverage Diff             @@
##            devel     #144      +/-   ##
==========================================
- Coverage   80.52%   76.19%   -4.33%     
==========================================
  Files         123      125       +2     
  Lines        8543     9104     +561     
  Branches     1437     1482      +45     
==========================================
+ Hits         6879     6937      +58     
- Misses       1031     1534     +503     
  Partials      633      633

Impacted Files	Coverage Δ
src/vpic/dump_strategy.h	`1.04% <1.04%> (ø)`
src/vpic/dump.cc	`52.54% <37.63%> (-5.63%)`	:arrow_down:
deck/main.cc	`47.27% <43.18%> (-10.18%)`	:arrow_down:
src/vpic/dump_strategy.cc	`60.65% <60.65%> (ø)`
src/vpic/vpic.h	`83.07% <81.66%> (-1.93%)`	:arrow_down:
src/vpic/vpic.cc	`100.00% <100.00%> (ø)`
test/unit/energy_comparison/3d_test.cc	`98.00% <100.00%> (+0.01%)`	:arrow_up:
test/unit/energy_comparison/weibel_driver.cc	`98.00% <100.00%> (ø)`
src/util/io/FileUtils.h	`0.00% <0.00%> (-66.67%)`	:arrow_down:
src/util/io/StandardUtilsPolicy.h	`0.00% <0.00%> (-40.00%)`	:arrow_down:
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

brtnfld commented 3 years ago

Brought branch current with devel:

CI test failing: particle_annotation_restart (Failed)

With the skipped test enabled, the same tests fail, as mentioned previously. 5 - particle_annotation_restart (Failed) 7 - buffered_particle_dump_restart (Failed) 8 - buffered_particle_dump_readhdf5 (Failed) 21 - perform_restore (Failed)

brtnfld commented 2 years ago

This implementation seems to have a minimum version of HDF5 requirement, so there should be a check for this in CMake.

lanl / vpic

[DO NOT MERGE] : WIP: Dump strategy branch in sync with devel #144

Codecov Report