search

lanl / vpic

Vector Particle-In-Cell (VPIC) Project
Other
152 stars 76 forks source link

WIP: Hdf5 for particle dumping #76

Closed rfbird closed 4 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #76 into devel will decrease coverage by 18.56%. The diff coverage is 62.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##            devel      #76       +/-   ##
===========================================
- Coverage   82.37%   63.81%   -18.57%     
===========================================
  Files         114      115        +1     
  Lines        6904    10528     +3624     
  Branches     1074     1495      +421     
===========================================
+ Hits         5687     6718     +1031     
- Misses        768     3273     +2505     
- Partials      449      537       +88
Impacted Files Coverage Δ
src/vpic/vpic.h 87.01% <ø> (+0.34%) :arrow_up:
src/vpic/vpic.cc 100% <100%> (ø) :arrow_up:
src/vpic/dump.cc 67.08% <100%> (+0.08%) :arrow_up:
src/grid/partition.cc 38.96% <50%> (+2.47%) :arrow_up:
src/util/pipelines/pipelines_thread.cc 60.74% <0%> (-0.94%) :arrow_down:
test/include/catch.hpp 28.35% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c4832c7...29da114. Read the comment docs.

rfbird commented 5 years ago

Howdy Bob, Saw this and got worried. Are you adding the capability to have a global particle index while also retaining the local p->i index in the particle struct? I hope so. BTW, is this the right way to comment on a GitHub commit? Seems a bit different from the past scenario where you have requested me to review pull requests, etc. Thanks, Dave

@dnystrom1 yea this is a fine way to comment on github, especially if you want to specifically address my work to extend the file IO to support HDF5

I have two branches currently:

This one -- where comments relating to "global id" are just so when we write the value of p->i (the particles cell) it's unique in global space

global_particle_id -- that adds a separate SoA that stores a globally unique id per particle

It sounds like you're referring to the second above, got but got scared by comment referring to the (unrelated) first?

Neither change at all how p->i functions and can be used

dnystrom1 commented 5 years ago

OK. Thanks. Good to know.

rfbird commented 4 years ago

Replace by #80