search

lanl / vpic

Vector Particle-In-Cell (VPIC) Project
Other
152 stars 76 forks source link

Fix Neon intrinsics fma, fms and fnms wrapper functions. #93

Closed dnystrom1 closed 4 years ago

dnystrom1 commented 4 years ago

There was a sign error for the fms implementation. Looks like Neon instrinsics to not have a single intrinsic to implement the VPIC definition of fms. Revert to using two chained intrinsics as at least the ARM clang compiler is smart enough to detect fmas and do the correct optimization.

codecov[bot] commented 4 years ago

Codecov Report

Merging #93 into devel will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            devel      #93   +/-   ##
=======================================
  Coverage   83.37%   83.37%           
=======================================
  Files         118      118           
  Lines        7322     7322           
  Branches     1124     1124           
=======================================
  Hits         6105     6105           
  Misses        734      734           
  Partials      483      483

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe617c6...fe617c6. Read the comment docs.