lanoxx / tilda

A Gtk based drop down terminal for Linux and Unix
GNU General Public License v2.0
1.28k stars 161 forks source link

Tilda fullscreen not working #151

Closed TildaUser closed 9 years ago

TildaUser commented 9 years ago

This has recently broken for me. I launch tilda and fullscreen works...then after toggling once or twice, it no longer works (tilda put into a window).

Running arch with the awesome wm.

Any ideas?

andrewlin16 commented 9 years ago

Can confirm I am getting this issue too. Fullscreen does not stick after the second toggle. Furthermore, pressing the fullscreen key does not make tilda fullscreen until the second press.

Using Arch Linux with Openbox.

richardpearl commented 9 years ago

Getting this issue too. Also Arch with Openbox.

pik commented 9 years ago

I'm using Arch w/ Openbox and don't have this issue? Can you guys add some package build details.

andrewlin16 commented 9 years ago

Not sure what details you need. Openbox is version 3.6-1. Tilda is from tilda-git on AUR, version 5a6c3df-1, though I can confirm I still get the issue on Arch's version of tilda.

pik commented 9 years ago

Nevermind, I was in fact able to reproduce the same bug - it actually took me 3 toggles though.

On Thu, Jun 4, 2015 at 12:23 PM, Andrew Lin notifications@github.com wrote:

Not sure what details you need. Openbox is version 3.6-1. Tilda is from tilda-git on AUR, version 5a6c3df https://github.com/lanoxx/tilda/commit/5a6c3dfcf4dd93ac445b334ef2e408411726cb03-1, though I can confirm I still get the issue on Arch's version of tilda.

— Reply to this email directly or view it on GitHub https://github.com/lanoxx/tilda/issues/151#issuecomment-108716744.

lanoxx commented 9 years ago

Does this bug only occur when using Openbox?

TildaUser commented 9 years ago

@lanoxx

No, I get it in awesome window manager too.

TildaUser commented 9 years ago

I had to revert back to gtk3-3.16.2 to get it to work again (there might be a later version where fullscreen works, but I just went to the earliest package in my cache).

lanoxx commented 9 years ago

Looks to me like some issue with gtk then. Tilda really just calls gtk_window_fullscreen and thats all. Maybe its worth to report a bug against GTK?

pik commented 9 years ago

Yes, it looks to be a gtk problem - https://github.com/pik/tilda/commit/a938e8bbc51b836f7562dc136e44688b42fdfa3f

newsgrep commented 9 years ago

I use tilda 1.2.4 and the 1.3-master-branch together with libgtk3 3.16.6.1 and i3wm 4.10.3. I do the following:

  1. open tilda --> I can see it but it is not fullscreen
  2. and switch it to fullscreen mode --> it turns fullscreen
  3. hide it by useing the hotkey --> tilda hides
  4. press tilda hotkey again --> it returns fullscreen
  5. hide it again by useing the hotkey --> tilda hides
  6. press tilda hotkey to return it like in 3. --> tilda returns not fullscreen
  7. when I switch to fullscreen mode again --> nothing happens

if I would try to turn to fullscreen mode once more the cycle would repeat. So it is not returned to fullscreen after hiding twice.

lanoxx commented 9 years ago

If I am not mistaken then Tilda was only affected by this on Gtk 3.16, I have recently pushed a fix that changes this for users of GTK 3.16, so closing this. If its still an issue feel free to reopen.