temporary fix for gtk breaking fullscreen show/hide

lanoxx / tilda

A Gtk based drop down terminal for Linux and Unix

GNU General Public License v2.0

1.28k stars 161 forks source link

temporary fix for gtk breaking fullscreen show/hide #174

Closed pik closed 9 years ago

pik commented 9 years ago

Sorry about how late this is, it could have been done much earlier. #151

At any rate, this is a temporary fix until we get to the new GTK version (3-17-5). I looked and the culprit code https://github.com/GNOME/gtk/blob/gtk-3-16/gtk/gtkwindow.c#L6032 appears to no longer exist in the current master of GTK. But I am running 3.17.1 on Arch and it appears to still be there (I should have reported this earlier), so it maybe sometime before everyone is running a GTK version without this bug.

lanoxx commented 9 years ago

This line was introduced here (which is on both the gtk-3-16 branch and master): https://github.com/GNOME/gtk/commit/7b2f3a0887f9d611dbf591a25f9bf80939cfb144 (branch for 3.16.x) https://github.com/GNOME/gtk/commit/740bcf5fe0ff9dd25856e5d000faff80bcf44eea (brach for 3.17.1) And later removed (but only in master): https://github.com/GNOME/gtk/commit/8b695cc7279270eabf7d2541cfd592608d0add38

So if I understand it right, this fix is only needed for users between Gtk 3.16 and 3.17.1?

pik commented 9 years ago

Yes, it seems that way; i could add a define that checks gtk version micro/minor - not sure if it matters for one line though.