search

lanoxx / tilda

A Gtk based drop down terminal for Linux and Unix
GNU General Public License v2.0
1.28k stars 161 forks source link

Feature request / (kind-of) regression: Give the terminal focus from start of animation #211

Open stevenhoneyman opened 8 years ago

stevenhoneyman commented 8 years ago

Since the animation behaviour change (I'm using the Arch linux provided build, so not sure when it appeared here), the terminal doesn't have focus until the animation has finished. This is an incredibly minor picky request I know, but would it be possible to revert to giving it focus as soon as the hotkey is pressed/animation starts?

Here's my reason/why it bothers me: maybe 8/10 startups, the very first thing I'll do is a full set of package updates. Routine used to be press the hotkey to open tilda, type command, hit enter. Now it's: press hotkey to open tilda, type command, hit enter, realise it's missed the first few characters because it didn't have focus at the time, retype the command, hit enter again!

pik commented 8 years ago

@lanoxx I know this code has some edge-cases (different WM's and all) but is there a reason we cannot call tilda_window_set_active (tw); (https://github.com/lanoxx/tilda/blob/master/src%2Fkey_grabber.c#L377) up here (before window-mode / sleep cycle): https://github.com/lanoxx/tilda/blob/master/src%2Fkey_grabber.c#L347 ?

lanoxx commented 8 years ago

@pik well actually I am not quite sure. I think I remember that during testing of the new animation code I had some problems when I did the activation earlier, but I it could also have been from some other issues that were still in the code while I was developing it. In the end I would probably need test it again with the earlier activation and make sure that it still works on all relevant window managers, inparticular this needs to work on mutter, metacity,xfwm4, and kwin. You can give it a try if you have the time to test with all window managers. Otherwise this needs to wait until I have more time.