lanoxx / tilda

A Gtk based drop down terminal for Linux and Unix

GNU General Public License v2.0

1.28k stars 161 forks source link

Bugfix for close-tab related issues (double-close / dialog close not working) #233

Closed pik closed 8 years ago

pik commented 8 years ago

Seems like we missed a GDK_EVENT_STOP since these accelerators technically get added twice ? https://github.com/lanoxx/tilda/blob/master/src%2Ftilda_terminal.c#L992

To replicate the original issue open/close the preferences dialog, then the will close two tabs at once and the on the menu will no longer work.

218 #229 #232

pik commented 8 years ago

Closing since this got merged with 39caf95 -- although I think there was a typo in my original commit message should be GDK not GTD (idk if you want to commit --amend that @lanoxx)

lanoxx commented 8 years ago

No, I don't want to force push to the master branch. Lets just leave it as it is.