lanoxx / tilda

A Gtk based drop down terminal for Linux and Unix
GNU General Public License v2.0
1.28k stars 161 forks source link

Replace eggaccelerator.c/h with native GTK+ code #274

Closed lanoxx closed 6 years ago

lanoxx commented 7 years ago

Unless I missed something, all the code in eggaccelerator.c/h can be removed and replaced by gtk_accelerator or gdk_keymap functions.

Essentially at any place where a EggVirtualModifierType is currently used it should be possible to replace that by a GdkModifierType value, since eventually all occurences of a EggVirtualModifierType are mapped to and from a GdkModifierType. Once that is done it should be easier to identify places where we can drop or replace functions from eggaccelerator.c/h

lanoxx commented 6 years ago

Fixed by recent commits:

The remaining code cannot be removed because GTK+ does not allow us to discover where scroll lock is bound.