search

lanoxx / tilda

A Gtk based drop down terminal for Linux and Unix
GNU General Public License v2.0
1.28k stars 161 forks source link

Fix for #291 #292

Closed GladOSkar closed 7 years ago

GladOSkar commented 7 years ago

Hello, previous to this commit, the master branch was broken because the function parse_cli tried to read from the config before the config was initialized.

parse_cli used these config values as 'default' values, which was unnecessary because the default Values were already set upon config initialization. The cli option overrides are applied afterwards by setup_config_from_cli_options.

So the fix was to apply zero-values to all cli options as defaults. This way, they will not be modified by setup_config_from_cli_options except if they are set explicitly.

GladOSkar commented 7 years ago

If you are still active, would you review this please? Afterwards i can start writing other patches, but noct as long as master is broken...

lanoxx commented 7 years ago

Merged with some small changes to commit message and I squashed both commits into one. Apologies for not reacting earlier. I somehow missed that this was such a critical issue. I also added two more commits that clean up the previous changes a little. Let me know if you catch any other issues.