lanoxx / tilda

A Gtk based drop down terminal for Linux and Unix
GNU General Public License v2.0
1.28k stars 161 forks source link

Incorrect "Solarized Light" palette #366

Closed egmontkob closed 4 years ago

egmontkob commented 6 years ago

The Solarized homepage defines exactly 1 mapping between its colors and the 0-15 indices, shown under the section "The Values". This mapping is implemented by Tilda as "Solarized Dark".

The two pictures under the section "Usage & Development" also clarify that there isn't another mapping for the "Light" variant, each color name and color index keeps the exact same RGB values. It's the application running inside the terminal emulator whose job is to pick different indices based on whether it wants to produce a "Dark" or a "Light" look.

As such, the existence of the "Solarized Light" palette defining the 16 colors in a shuffled way is conceptually broken. There should be only one "Solarized" palette. (Offering the Light and Dark variants for the default foreground/background colors, as you do now, is fine.)