search

lanoxx / tilda

A Gtk based drop down terminal for Linux and Unix
GNU General Public License v2.0
1.27k stars 162 forks source link

tilda fullscreen toggle does not return to original size #371

Closed stumper932 closed 4 years ago

stumper932 commented 5 years ago

Expected behaviour Return from fullscreen to size set in preferences under height width

Actual behaviour Return from fullscreen to default screen size before set in preferences (?)

Steps to reproduce the behaviour (F12 Pull Down Terminal) (F11 Toggle Full Screen) F12 F11 F12 F12 F11

Package version tilda/bionic,now 1.4.1-2 amd64

Linux Distribution ubuntu-mate 18.04.1 lts

stumper932 commented 5 years ago

Updated original comment after i found out how to reproduce the behaviour. Attached video: tilda_screensize_bug.mkv.zip

stumper932 commented 5 years ago

This could be a possible duplicate of #225 and #297

thiswillbeyourgithub commented 5 years ago

I have the exact same issue on Ubuntu 18.04 LTS gnome :/

thiswillbeyourgithub commented 5 years ago

Edit : my workarround so far has been to keep the fullscreen key pressed for a second or so and stop. Sometimes it returned to it's original position.

stumper932 commented 5 years ago

Workaround: right-mouse click -> preferences -> appearance tab -> increase height or width -> decrease height or width.

thiswillbeyourgithub commented 5 years ago

Thanks ! I actually ticked "expand tabs" and it sems to fix it. Thanks to you !

nvmd, it came back...

stumper932 commented 5 years ago

Yeah, you have to do this every time =/ .. maybe we should throw some $ to the developer to speed up the process.

thiswillbeyourgithub commented 5 years ago

I still prefer to press the fullscreen shortcut like mad than to do all your clicky things.

Do you know how we could send monizz to the developper ?

nshell32 commented 5 years ago

Maybe the problem is in normal window size restoring after unset full screen. When I set fullscreen, then pressed Alt and left mouse button, nothing has happened. But when I tried to unset fullscreen and pressed Alt + left mouse button the window started to drag with cursor that didn't on fullscreen. Therefore, the problem could be in normal window size height and width restoring.

makemegit commented 5 years ago

I found out that if you switch to compiz, everything works fine. I am on Ubuntu Mate 16.04 and 18.04, and i think there is some incompatibility with the window manager.

solacelost commented 5 years ago

There have been a lot of updates since I made this PR but supposedly it's still working for people today: https://github.com/lanoxx/tilda/pull/365 Let me know if the patch works for you.

lanoxx commented 4 years ago

I can reproduce this with the marco window manager of the mate desktop, but not with the metacity window manager. When the error occurs then marco prints:

Window manager warning: Treating resize request of legacy application 0x3200007 (~/Document) as a fullscreen request

With metacity the window just returns to the expected size. Could you tell me if using metacity fixes the problem for you? Just run metacity --replace & on a shell and try to reproduce the problem.

lanoxx commented 4 years ago

There have been changes to the fullscreen code in 4c252136ec5a6393fb530f9b17a39b62f385c219

Closing as duplicate of #225, #306, #371.