search

lanoxx / tilda

A Gtk based drop down terminal for Linux and Unix
GNU General Public License v2.0
1.27k stars 162 forks source link

Url-parsing cuts on at-sign "@" #404

Closed demlak closed 4 years ago

demlak commented 4 years ago

Hi, i'm using tilda 1.5.0 and when there are urls detected, those are cut at at-sign "@"

for xample https://www.flickr.com/photos/22047531@N03/49224861571/ is detected as https://www.flickr.com/photos/22047531 for clicking on it

lanoxx commented 4 years ago

There was a change to the URL detection code, but I do not think that it caused this issue: https://github.com/lanoxx/tilda/commit/2a0f9fbbded7d0efa67cf1ef3f44b514d87eb514

Can you confirm if this worked in an older version of tilda?

demlak commented 4 years ago

i can confirm that in 1.4.1 the behaviour is the same

lanoxx commented 4 years ago

Then its not a regression but never the less something that should be fixed.

demlak commented 4 years ago

thx a lot for your fast reactions.. (i was responsible for the other url parser issue taht you fixed)

lanoxx commented 4 years ago

URL handling is really a complex matter and any solution in tilda is probably bound to have some limits, especially since URLs are evolving over time. I am considering to make this configurable via a UI option so users can tweak the Regex that is used for matching URLs. Nevertheless we should probably improve the default and add some more special cases to the regex.

The default is defined here: https://github.com/lanoxx/tilda/blob/master/src/tilda_terminal.c#L35

Feel free to make some suggestions of a better regular expression.

demlak commented 4 years ago

since i cant speak regex, i'm totaly lost..

but well.. i think, there must be anyone else on the planet who has managed a good one? this is for sure no specialised problem.. and more wide spread?

but i like the idea, that every user can change the regex in the settings

lanoxx commented 4 years ago

Fixed in master by commit e4b6757364dbbf60f064f8036df96ef906251d39 and in tilda-1-5 by commit 919afad771ad815dd54875c6788d49827698bffa.

lanoxx commented 4 years ago

I have created a stable release update for Ubuntu 20.04 focal which is currently in the proposed updates and should become available once the package moves into the updates repository.